Skip to content

Commit

Permalink
[BUGFIX] - Reverting readOnly for two fields
Browse files Browse the repository at this point in the history
* In this already-merged PR
(Azure#1429), Ben made some
object-refactoring changes - one of them being to make all the fields in
USqlJobProperties read-only as a good design decision.  However, by
making the fields statistics and debugData read-only, this caused some
conflicts in the Powershell code.  We need to pan out the design more
carefully for these two fields with respect to their associated APIs
("/Jobs/{jobIdentity}/GetDebugDataPath" for the debugData field and
"/Jobs/{jobIdentity}/GetStatistics" for the statistics field) before
making them read-only.  If I do not make the change proposed here, I
would have to create two new cmdlets: one for getting the JobDataPath
object and another for getting the JobStatistics object, which we do not
want to do until we have a better understanding of their designs as a
whole.  Hence, the reverting change proposed here.
  • Loading branch information
ro-joowan committed Aug 26, 2017
1 parent 27907bf commit 1827ad4
Showing 1 changed file with 0 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -747,12 +747,10 @@
},
"statistics": {
"$ref": "#/definitions/JobStatistics",
"readOnly": true,
"description": "the job specific statistics."
},
"debugData": {
"$ref": "#/definitions/JobDataPath",
"readOnly": true,
"description": "the job specific debug data locations."
},
"diagnostics": {
Expand Down

0 comments on commit 1827ad4

Please sign in to comment.