Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Set codepage to utf-8 for msys2 tests run. #2286

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

ni4
Copy link
Contributor

@ni4 ni4 commented Nov 4, 2024

Details on why this happened: msys2/MINGW-packages#22462 (comment)

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.67%. Comparing base (9077b2d) to head (ff7f7d2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2286   +/-   ##
=======================================
  Coverage   84.67%   84.67%           
=======================================
  Files         116      116           
  Lines       23436    23436           
=======================================
  Hits        19844    19844           
  Misses       3592     3592           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ni4 ni4 force-pushed the ni4-fix-windows-codepage-failure branch 6 times, most recently from 0c28342 to 7f14971 Compare November 9, 2024 11:19
@ni4 ni4 force-pushed the ni4-fix-windows-codepage-failure branch from 90477cb to ff7f7d2 Compare November 9, 2024 12:57
@ni4
Copy link
Contributor Author

ni4 commented Nov 10, 2024

Thanks, @desvxx ! Merging with one approval as CI-only.

@ni4 ni4 merged commit 135775a into main Nov 10, 2024
124 checks passed
@ni4 ni4 deleted the ni4-fix-windows-codepage-failure branch November 10, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants