Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the version header from armored messages. #1113

Merged
merged 2 commits into from
May 6, 2020

Conversation

joke325
Copy link
Contributor

@joke325 joke325 commented Apr 28, 2020

Closes #871

@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #1113 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1113   +/-   ##
=======================================
  Coverage   83.40%   83.40%           
=======================================
  Files          76       76           
  Lines       29720    29716    -4     
=======================================
- Hits        24788    24786    -2     
+ Misses       4932     4930    -2     
Impacted Files Coverage Δ
src/librepgp/stream-armor.cpp 86.23% <ø> (-0.11%) ⬇️
src/librepgp/stream-write.cpp 78.82% <0.00%> (-0.11%) ⬇️
src/librepgp/stream-parse.cpp 77.75% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdd948e...74f9c74. Read the comment docs.

@dewyatt dewyatt force-pushed the joke325-issue871 branch from 89f2755 to 3ebff45 Compare May 5, 2020 13:54
@ronaldtse
Copy link
Contributor

Failure in CentOS:

-- Configuring incomplete, errors occurred!
305
CMake Error at cmake/version.cmake:104 (file):
306
  file STRINGS file "/__w/rnp/rnp/version.txt" cannot be read.
307
Call Stack (most recent call first):
308
  CMakeLists.txt:41 (determine_version)
309

310

311
CMake Error at cmake/version.cmake:55 (message):
312
  Failed to extract version components.
313
Call Stack (most recent call first):
314
  cmake/version.cmake:107 (extract_version_info)
315
  CMakeLists.txt:41 (determine_version)
316

317

318

@dewyatt dewyatt force-pushed the joke325-issue871 branch from 234d408 to da50434 Compare May 5, 2020 19:48
There's a race condition with v1 that we seem to be encountering.
@dewyatt dewyatt force-pushed the joke325-issue871 branch from da50434 to 74f9c74 Compare May 5, 2020 20:21
@dewyatt
Copy link
Contributor

dewyatt commented May 5, 2020

Failure in CentOS:

I think it should be ok now. Initially we were encountering actions/checkout#222 so I upgraded to actions/checkout@v2, but the version of git present in centos is too old for normal use with that action, so we end up missing the .git folder (it falls back to downloading via REST) which is where that error comes from. I added a step to install a newer git for centos, let's see how that goes.

@dewyatt dewyatt requested review from ni4, ronaldtse and rrrooommmaaa May 5, 2020 21:41
@ronaldtse
Copy link
Contributor

Worked perfectly @dewyatt. Thanks!

@ronaldtse ronaldtse merged commit 45db44f into rnpgp:master May 6, 2020
@ni4 ni4 added this to the v0.14.0 milestone Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Version: header from armored messages.
4 participants