-
-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support AndroidX #240
Support AndroidX #240
Conversation
I can confirm that Android form this PR works. But still running into issues with iOS 😕 |
I mean, this wasn't supposed to address iOS issues, and a new issue is probably a better place to discuss, but what issues are you having? Because I need iOS support on 0.60.x too and haven't tried it out yet |
@jshearer I get sth like |
Ok cool, thanks :) I'll check it out too and see what I find.
…On Sat, Jul 13, 2019, 2:28 PM Damian Sznajder ***@***.***> wrote:
@jshearer <https://github.com/jshearer> I get sth like cannot read
StyleURL of undefined. Seems like maybe I messed up with autolinking. I
will investigate the problem more and maybe came back with solution. I know
that it isn't iOS related. Just making a note for future people :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/react-native-mapbox-gl/maps/pull/240?email_source=notifications&email_token=ABBKPDTAYYBODPRTPYRN3SLP7INGLA5CNFSM4IB52LO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ3W75Y#issuecomment-511143927>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABBKPDSMJXVII3GNETPCA63P7INGLANCNFSM4IB52LOQ>
.
|
@jshearer Ok, I've messed up autolinking :) iOS works fine :) |
@dsznajder hello, were you able to get Android build to work properly? I had a similar issue with the StyleURL on the Android side. If so how were you able to get the fix? |
Looks good. I would make use of the previously present safeExtGet with fallback values function to allow the root project to override used versions with |
The example app needs to be updated to AndroidX as well, which is why the integration tests are currently failing. |
@DavidKHahn Yes I've already upgraded my app to 60.3. What issues you have? Have you added linking properly? |
Thanks for this PR. Issues that I am experiencing are that custom marker is not displayed, the default one is displayed instead, and the map is zoomed out. |
this working @react-native: 0.60.3 ✅ |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This project has dependencies on
com.android.support
that were causing trouble with androidx. I understand that this change is backwards incompatible and will only work with RN 0.60.x+, but maybe it'll be a helpful starting point in getting others unblocked.To test drive this, you can do:
in your
package.json
.I honestly don't have that much familiarity with Java, so I'm not sure if this is a complete solution, or even the correct one.
Relates to #163