Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AndroidX #240

Closed
wants to merge 5 commits into from
Closed

Support AndroidX #240

wants to merge 5 commits into from

Conversation

jshearer
Copy link

This project has dependencies on com.android.support that were causing trouble with androidx. I understand that this change is backwards incompatible and will only work with RN 0.60.x+, but maybe it'll be a helpful starting point in getting others unblocked.

To test drive this, you can do:

"@react-native-mapbox-gl/maps": "jshearer/maps",

in your package.json.

I honestly don't have that much familiarity with Java, so I'm not sure if this is a complete solution, or even the correct one.

Relates to #163

@ice-chillios
Copy link
Contributor

I can confirm that Android form this PR works. But still running into issues with iOS 😕

@jshearer
Copy link
Author

jshearer commented Jul 13, 2019

I mean, this wasn't supposed to address iOS issues, and a new issue is probably a better place to discuss, but what issues are you having? Because I need iOS support on 0.60.x too and haven't tried it out yet

@ice-chillios
Copy link
Contributor

@jshearer I get sth like cannot read StyleURL of undefined. Seems like maybe I messed up with autolinking. I will investigate the problem more and maybe came back with solution. I know that it isn't iOS related. Just making a note for future people :)

@jshearer
Copy link
Author

jshearer commented Jul 13, 2019 via email

@ice-chillios
Copy link
Contributor

@jshearer Ok, I've messed up autolinking :) iOS works fine :)

@DavidKHahn
Copy link

@dsznajder hello, were you able to get Android build to work properly? I had a similar issue with the StyleURL on the Android side. If so how were you able to get the fix?

@mattijsf
Copy link
Member

Looks good. I would make use of the previously present safeExtGet with fallback values function to allow the root project to override used versions with annotationVersion / appCompatVersion / vectordrawableVersion

@mattijsf
Copy link
Member

The example app needs to be updated to AndroidX as well, which is why the integration tests are currently failing.

@ice-chillios
Copy link
Contributor

ice-chillios commented Jul 15, 2019

@DavidKHahn Yes I've already upgraded my app to 60.3. What issues you have? Have you added linking properly?

@zeljkoX
Copy link

zeljkoX commented Jul 16, 2019

Thanks for this PR.
I confirm that it is working on v0.60.

Issues that I am experiencing are that custom marker is not displayed, the default one is displayed instead, and the map is zoomed out.

@mustafaskyer
Copy link

this working @react-native: 0.60.3 ✅

@stale
Copy link

stale bot commented Oct 25, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 25, 2019
@stale stale bot closed this Nov 1, 2019
@mfazekas
Copy link
Contributor

mfazekas commented Feb 3, 2020

@jshearer as per #610 we'd like to upgrade to androidx for 8.0.0, would you like to update your PR?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants