ci: two scripts for linting with and without fix #1630
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the script
yarn lint
includes the--fix
option.As this script runs on GH actions too, the freshly formatted files - if any - would not be recognized / pushed to the repo.
With differentiating the two scripts
yarn lint
andyarn lin:fix
it is easier to decide when to use what:yarn lint
without--fix
to let the workflow fail when a file is not formatted correctlyyarn lint
without--fix
in order to check wrong formatted files first before pushing to remoteyarn lint:fix
locally and commit formatted files accordingly (mentioned in the PR template)Checklist
yarn lint
yarn generate
CHANGELOG.md
index.d.ts
)/example
)Screenshot OR Video