Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Native
EventEmitters
api seems to have slightly changed.They expect a
addListener
removeListener
method on the native modules.Would be showing warning messages like these:
'new NativeEventEmitter() was called with a non-null argument without the required addListener method.'
See: facebook/react-native@114be1d
Additionally,
EventEmitter.js
itself does changeremoveListener
=> justremove
, which is called on the return value ofaddListener
.I've changed the code accordingly.
Would be showing warning messages like these:
EventEmitter.removeListener(): Method has been deprecated. Please instead use remove() on the subscription returned by EventEmitter.addListener.
What I didn't do where extensive test on those components/ files.
I've did some simple playing around within the
example
app - would appreciate some full fledged tests with this PR thoughFixes #1594
Checklist
yarn lint
CHANGELOG.md