Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve GH workflows #1588

Merged
merged 7 commits into from
Oct 21, 2021
Merged

chore: improve GH workflows #1588

merged 7 commits into from
Oct 21, 2021

Conversation

lisabaut
Copy link
Contributor

@lisabaut lisabaut commented Oct 21, 2021

Description

This PR improves the current workflow set-up as such:

  • include the script yarn lint
  • make iOS workflow a re-usable workflow (=> see the docs for more information)
  • make android workflow a re-usable workflow
  • read the node version from the nvmrc file
  • pass this node version to all workflow jobs

Re-usable workflows need to be addressed directly with the correct path (tag, commit-hash, branch name)
In order to prove that everything is working I needed to point the workflows to this branch of this PR.

See the succesfull Working Workflow here (which points to this branch to avoid errors)
https://github.com/react-native-mapbox-gl/maps/actions/runs/1367197447

The next commits in this PR will replace the path again to master in order to make the actions run successfully when merged to master.
But this led to failing actions on this PR again of course. Just to let you know that this was expected. (=> failing action run)

In general, one can go more wild now with the extracted and re-usable workflows, like for example:

  • extract the publish job and create a dedicated workflow file for releases and re-use the iOS and Android workflow
  • do some other actions when a PR was opened and re-use the workflows again
  • other ideas

Checklist

  • I have tested this on a device/simulator for each compatible OS
  • I formatted JS and TS files with yarn lint
  • I updated the documentation yarn generate
  • I mentioned this change in CHANGELOG.md
  • I updated the typings files (index.d.ts)
  • I added/ updated a sample (/example)

Screenshot OR Video

@lisabaut lisabaut self-assigned this Oct 21, 2021
Copy link
Member

@ferdicus ferdicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good 👍🏿

@ferdicus ferdicus merged commit 4a93e90 into master Oct 21, 2021
@ferdicus ferdicus deleted the chore/workflow-on-push branch October 21, 2021 14:25
sdacunha pushed a commit to sdacunha/maps that referenced this pull request Oct 25, 2021
* refactor: make ios to a re-usable workflow

* refactor: make android to a re-usable workflow

* feat: set-up worflow on push with all actions

* fix: pass secrets correctly to other workflow

* fix: define required input type

* chore: changelog

* refactor: change to correct branch when merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants