Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(example): update vertical alignment example #1579

Merged
merged 2 commits into from
Oct 15, 2021

Conversation

ferdicus
Copy link
Member

@ferdicus ferdicus commented Oct 15, 2021

Description

Update /examples SetUserLocationVerticalAlignment.js example.
This is now achieved via MapViews contentInset prop.

Not perfect (see: attributions also being moved), however works 👍🏿

Checklist

  • I have tested this on a device/simulator for each compatible OS
  • I updated the documentation yarn generate
  • I mentioned this change in CHANGELOG.md
  • I updated the typings files (index.d.ts)
  • I added/ updated a sample (/example)

Screenshot OR Video

Simulator.Screen.Recording.-.iPhone.SE.2nd.generation.-.2021-10-14.at.12.08.09.mp4

@ferdicus ferdicus merged commit 22df62c into master Oct 15, 2021
@ferdicus ferdicus deleted the feat/update-vertical-alignment-example branch October 15, 2021 15:50
sdacunha pushed a commit to sdacunha/maps that referenced this pull request Oct 25, 2021
* feat(example): update vertical alignment example

* update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant