Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(example): align install steps with yarn, ignore created env files #1484

Merged
merged 3 commits into from
Aug 5, 2021
Merged

chore(example): align install steps with yarn, ignore created env files #1484

merged 3 commits into from
Aug 5, 2021

Conversation

lisabaut
Copy link
Contributor

@lisabaut lisabaut commented Aug 5, 2021 •
edited
Loading

Description

During my first time setting-up the repository and the examples I stumbled over these minor improvements.

This PR does:

  • align the example docs with yarn (and not npm)
  • add the created env-files from the set-up to gitignore

Checklist

  • I have tested this on a device/simulator for each compatible OS
  • I updated the documentation yarn generate
  • I mentioned this change in CHANGELOG.md
  • I updated the typings files (index.d.ts)
  • I added/ updated a sample (/example)

@ferdicus
Copy link
Member

ferdicus commented Aug 5, 2021

Thanks

@ferdicus ferdicus merged commit f38ff0b into rnmapbox:master Aug 5, 2021
mikalaiulasevich pushed a commit to OneSoil-Platform/maps that referenced this pull request Sep 23, 2021
@lisabaut @mikalaiulasevich
chore(example): align install steps with yarn, ignore created env fil…
9477e9c 
…es (rnmapbox#1484)

* chore: add env files to gitignore

* docs: align text with yarn instead of npm

* chore: update Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lisabaut @ferdicus