Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lineGradient showing wrong colors #1471

Merged
merged 5 commits into from
Jul 30, 2021

Conversation

chuchuva
Copy link
Contributor

@chuchuva chuchuva commented Jul 25, 2021

Description

Fixes #1272

lineMetrics property was missing.

Checklist

  • I have tested this on a device/simulator for each compatible OS
  • I updated the documentation yarn generate
  • I mentioned this change in CHANGELOG.md
  • I updated the typings files (index.d.ts)
  • I added/ updated a sample (/example)

Screenshot

Screenshot line gradient

Simulator Screen Shot - iPhone 11 - 2021-07-25 at 13 29 39

@chuchuva chuchuva changed the title Fix/gradient line Fix lineGradient showing wrong colors Jul 25, 2021
Copy link
Member

@ferdicus ferdicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @chuchuva, thanks for this kick-ass PR 🙇🏿 👍🏿 🚀

@ferdicus ferdicus merged commit 906f46b into rnmapbox:master Jul 30, 2021
@chuchuva chuchuva deleted the fix/gradient-line branch July 30, 2021 10:33
@julioxavierr
Copy link

@chuchuva awesome!!

mikalaiulasevich pushed a commit to OneSoil-Platform/maps that referenced this pull request Sep 23, 2021
* Fix lineGradient showing wrong colors

`lineMetrics` property was missing.

Fixes https://github.com/react-native-mapbox-gl/maps/issues/1272

* Add line gradient example

* Re-generate documentation

* Update CHANGELOG.md

Co-authored-by: Kid Commit <[email protected]>
mikalaiulasevich pushed a commit to OneSoil-Platform/maps that referenced this pull request Sep 23, 2021
* Fix lineGradient showing wrong colors

`lineMetrics` property was missing.

Fixes https://github.com/react-native-mapbox-gl/maps/issues/1272

* Add line gradient example

* Re-generate documentation

* Update CHANGELOG.md

Co-authored-by: Kid Commit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradient line does not display properly
3 participants