Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android): dynamically update tintColor #1469

Merged
merged 3 commits into from
Jul 30, 2021
Merged

feat(android): dynamically update tintColor #1469

merged 3 commits into from
Jul 30, 2021

Conversation

ferdicus
Copy link
Member

@ferdicus ferdicus commented Jul 23, 2021 •
edited
Loading

Description

PR #1465 added editing of tintColor for Android, unfortunately it didn't update dynamically.

This extends that PR with that functionality and adds a Set Tint Color example

Checklist

  • I have tested this on a device/simulator for each compatible OS
  • I mentioned this change in CHANGELOG.md
  • I added/ updated a sample (/example)

Screenshot

iOS

red yellow green
Simulator Screen Shot - iPhone SE (2nd generation) - 2021-07-23 at 12 27 04 Simulator Screen Shot - iPhone SE (2nd generation) - 2021-07-23 at 12 27 07 Simulator Screen Shot - iPhone SE (2nd generation) - 2021-07-23 at 12 27 10

Android

read yellow green
android_screenshot_emulator-5554_21-07-23_14 52 41 android_screenshot_emulator-5554_21-07-23_14 52 52 android_screenshot_emulator-5554_21-07-23_14 52 59

@ferdicus ferdicus changed the title feat: add tintColor example feat(android): dynamically update tintColor Jul 23, 2021
@ferdicus
Copy link
Member Author

@janicduplessis, can you have a look please if you find the time?
Thanks in advance

janicduplessis
janicduplessis approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@janicduplessis janicduplessis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I didn’t have a use case for updating it so thanks for testing and fixing that :)

@ferdicus
Copy link
Member Author

Looks good! I didn’t have a use case for updating it so thanks for testing and fixing that :)

Just for feature parity - works in iOS, people will probably expect it to work on Android the same 👍🏿

Thanks

@ferdicus ferdicus merged commit fce82f1 into master Jul 30, 2021
@ferdicus ferdicus deleted the example/map-set-tint-color branch July 30, 2021 08:40
mikalaiulasevich pushed a commit to OneSoil-Platform/maps that referenced this pull request Sep 23, 2021
@ferdicus @mikalaiulasevich
feat(android): dynamically update tintColor (rnmapbox#1469)
cf608f4 
* feat: add tintColor example

* feat(android): dynamically update tintColor

* docs: update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janicduplessis janicduplessis janicduplessis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ferdicus @janicduplessis