build(ios): pin maplibre version to 5.12.0 #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferdicus
force-pushed
the
feat/pin-maplibre-version
branch
from
360ebd7
to
28dd14b
Compare
mfazekas
approved these changes
Jul 16, 2021
| @@ -36,8 +36,8 @@ def $RNMBGL.post_install(installer) | |||
| spm_spec = { | |||
| url: "https://github.com/maplibre/maplibre-gl-native-distribution", | |||
| requirement: { | |||
| kind: "upToNextMajorVersion", | |||
| minimumVersion: "5.11.0" | |||
| kind: "exactVersion", | |||
There was a problem hiding this comment.
I'd probably went with kind = upToNextMinorVersion;. minimumVersion = 5.12.0
There was a problem hiding this comment.
I think people got confused, when it downloaded the new version - they didn't have it on their radar, hence why I locked it down.
mikalaiulasevich
pushed a commit
to OneSoil-Platform/maps
that referenced
this pull request
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Saw a post in the gitter chat that mentioned, that their MapLibre version upgraded without them noticing/ wanting.
This pins down the version to
exact5.12.0(new release of MapLibre).Also adjusted the install docs.
Checklist
CHANGELOG.md