Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with React 17 #1387

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Add compatibility with React 17 #1387

merged 1 commit into from
Jun 18, 2021

Conversation

arabold
Copy link
Contributor

@arabold arabold commented Jun 5, 2021

Description

Fixes #1386

Checklist

  • I have tested this on a device/simulator for each compatible OS
  • I updated the documentation yarn generate
  • I mentioned this change in CHANGELOG.md
  • I updated the typings files (index.d.ts)
  • I added/ updated a sample (/example)

package.json Outdated Show resolved Hide resolved
@@ -65,7 +65,7 @@
"lint-staged": "^11.0.0",
"metro-react-native-babel-preset": "0.49.1",
"node-dir": "0.1.17",
"react": "16.8.6",
"react": "16.8.3",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the version compatible with "react-native": "0.59.10" below. Either we need to upgrade react-native or keep this to 16.8.3 to avoid peer dependency errors in npm 7. In any case, this shouldn't really matter here.

@ferdicus
Copy link
Member

thanks @arabold

@ferdicus ferdicus merged commit 70612b0 into rnmapbox:master Jun 18, 2021
ferdicus added a commit that referenced this pull request Jun 18, 2021
mikalaiulasevich pushed a commit to OneSoil-Platform/maps that referenced this pull request Sep 23, 2021
mikalaiulasevich pushed a commit to OneSoil-Platform/maps that referenced this pull request Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update peer dependency to allow React 17
2 participants