Add some missing props to TypeScript lib def #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution 🙇🏿 |
mikalaiulasevich
pushed a commit
to OneSoil-Platform/maps
that referenced
this pull request
Sep 23, 2021
* Add some missing props to TypeScript lib def * Add changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds some missing props to the TypeScript lib def file that I have encountered.
I am aware of #1067, but I guess it will still take some time before that one is merged and released.
I have not used
onImageMissingmyself, but from looking at the source code it seems like this function is called with the name of the missing image as a string. Please correct me if I'm wrong.Checklist
yarn generateCHANGELOG.mdindex.d.ts)/example)