feat(ts): add types for Logger class #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClayC-WeatherBug
approved these changes
Apr 19, 2021
|
I added a couple suggestions/questions, but I wouldn't block this PR for those items. |
mikalaiulasevich
pushed a commit
to OneSoil-Platform/maps
that referenced
this pull request
Sep 23, 2021
* feat(ts): add types for Logger class * update changelog * refactor(ts): review comments * docs(Logger): add Logger docs [by hand 😭]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the title implies, this adds types for the public methods of the
Loggerclass.This should be enough to us it in a
.ts|xfile without it screaming in agony.Fixes #1289
Checklist
[ ] I have tested this on a device/simulator for each compatible OSyarn generateCHANGELOG.mdindex.d.ts)[ ] I added/ updated a sample (/example)