-
-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update install.md for ios: Mapbox Maps SDK #1106
Conversation
Following ticket https://github.com/react-native-mapbox-gl/maps/issues/1103 to explain how to use a custom version of the Mapbox Maps SDK for iOS.
Hey @mzu, thanks for this 👍🏿 One suggestion: Instead of linking to the PR, could you instead have the instructions mirrored in the installation guide please. Thanks in advance 🙇🏿 |
Hi @ferdicus. Added the instructions. Hope the formatting looks ok. |
ios/install.md
Outdated
|
||
Check the current version of the SDK [here](https://docs.mapbox.com/ios/maps/overview/). | ||
|
||
### Deprecated version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove the deprecated section?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also we need to at least a note on using 6.0 and later.
https://github.com/react-native-mapbox-gl/maps/pull/1044#issue-493540536
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove the deprecated section?!
That's done now.
Also we need to at least a note on using 6.0 and later.
There is the already existing section "Mapbox Maps SDK > v6.0.0
". Does this cover it?
Thanks for this @mzu, merging this for now - we can alter it later. |
* commit '227e46a596b9b3ec5afb975092e63288396f3f80': Update package.json Update package.json ~>5.9.0 is the equivalent for ~>5.8 dep we've used before Make errors during remove source a warning rather than a hard error Update LICENSE.md Update install.md for ios: Mapbox Maps SDK (rnmapbox#1106) Prevent emitting log events without listeners increase node version 10.XX.1 => 14.15.0 (rnmapbox#1100) Remove flow dependency (rnmapbox#1101) Update all development npm dependencies (2020-11-06) (rnmapbox#1098) Update all development npm dependencies (2020-10-05) (rnmapbox#1056)
* Update install.md Following ticket https://github.com/react-native-mapbox-gl/maps/issues/1103 to explain how to use a custom version of the Mapbox Maps SDK for iOS. * Update install.md * Removed section for deprecated version
Following ticket https://github.com/react-native-mapbox-gl/maps/issues/1103 to explain how to use a custom version of the Mapbox Maps SDK for iOS.