Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install.md for ios: Mapbox Maps SDK #1106

Merged
merged 3 commits into from
Nov 20, 2020
Merged

Conversation

mzu
Copy link
Contributor

@mzu mzu commented Nov 13, 2020

Following ticket https://github.com/react-native-mapbox-gl/maps/issues/1103 to explain how to use a custom version of the Mapbox Maps SDK for iOS.

Following ticket https://github.com/react-native-mapbox-gl/maps/issues/1103 to explain how to use a custom version of the Mapbox Maps SDK for iOS.
@ferdicus
Copy link
Member

Hey @mzu, thanks for this 👍🏿

One suggestion: Instead of linking to the PR, could you instead have the instructions mirrored in the installation guide please.
I know it's basically duplicating the info - however I feel like the guide should rather be the nexus for such info instead of linking to a PR.

Thanks in advance 🙇🏿

@mzu
Copy link
Contributor Author

mzu commented Nov 13, 2020

Hi @ferdicus.

Added the instructions. Hope the formatting looks ok.

ios/install.md Outdated

Check the current version of the SDK [here](https://docs.mapbox.com/ios/maps/overview/).

### Deprecated version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the deprecated section?!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we need to at least a note on using 6.0 and later.

https://github.com/react-native-mapbox-gl/maps/pull/1044#issue-493540536

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the deprecated section?!

That's done now.

Also we need to at least a note on using 6.0 and later.

#1044 (comment)

There is the already existing section "Mapbox Maps SDK > v6.0.0". Does this cover it?

@ferdicus
Copy link
Member

Thanks for this @mzu, merging this for now - we can alter it later.
I feel it's good to have it already included so we can point at it and people can discover it - instead of us redirecting people to comments and PRs 👍🏿

@ferdicus ferdicus merged commit 000616c into rnmapbox:master Nov 20, 2020
jaysquared added a commit to jaysquared/maps that referenced this pull request Dec 9, 2020
* commit '227e46a596b9b3ec5afb975092e63288396f3f80':
  Update package.json
  Update package.json
  ~>5.9.0 is the equivalent for ~>5.8 dep we've used before
  Make errors during remove source a warning rather than a hard error
  Update LICENSE.md
  Update install.md for ios: Mapbox Maps SDK (rnmapbox#1106)
  Prevent emitting log events without listeners
  increase node version 10.XX.1 => 14.15.0 (rnmapbox#1100)
  Remove flow dependency (rnmapbox#1101)
  Update all development npm dependencies (2020-11-06) (rnmapbox#1098)
  Update all development npm dependencies (2020-10-05) (rnmapbox#1056)
naftalibeder pushed a commit to TruckMap/maps that referenced this pull request Mar 22, 2021
* Update install.md

Following ticket https://github.com/react-native-mapbox-gl/maps/issues/1103 to explain how to use a custom version of the Mapbox Maps SDK for iOS.

* Update install.md

* Removed section for deprecated version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants