[Bug]: Error in ViewAnnotationManager.swift when running React Native app on iOS 18

[guneyural]

Mapbox Implementation

Mapbox

Mapbox Version

= 11.4.0

React Native Version

0.74.3

Platform

iOS

@rnmapbox/maps version

^10.0.0-beta.28

Standalone component to reproduce

Steps to Reproduce

1. Upgrade iOS version to 18 and Xcode to 16.0
2. Install the latest version of rnmapbox/maps and MapboxMaps.
3. Run the React Native app using `npm run ios`.

import React from 'react';
import {
  MapView,
  ShapeSource,
  LineLayer,
  Camera,
} from '@rnmapbox/maps';

const aLine = {
  type: 'LineString',
  coordinates: [
    [-74.00597, 40.71427],
    [-74.00697, 40.71527],
  ],
};

class BugReportExample extends React.Component {
  render() {
    return (
      <MapView style={{flex: 1}}>
        <Camera centerCoordinate={[-74.00597, 40.71427]} zoomLevel={14} />
        <ShapeSource id="idStreetLayer" shape={aLine}>
          <LineLayer id="idStreetLayer" />
        </ShapeSource>
      </MapView>
    );
  }
}

Observed behavior and steps to reproduce

I am experiencing an issue when running my React Native application using the rnmapbox/maps library on iOS 18 and xcode 16.0

Before the update there was no problem.

The build fails with a Swift type conversion error in ViewAnnotationManager.swift.

❌  (ios/Pods/MapboxMaps/Sources/MapboxMaps/Annotations/ViewAnnotationManager.swift:79:19)

  77 |     @available(*, deprecated, message: "Use ViewAnnotation")
  78 |     public var annotations: [UIView: ViewAnnotationOptions] {
> 79 |         idsByView.compactMapValues { [mapboxMap] id in
     |                   ^ cannot convert return expression of type '[UIView : ViewAnnotationOptions]' to return type 'Dictionary<String, Optional<JSONValue>>.RawValue' 
  80 |             try? mapboxMap.options(forViewAnnotationWithId: id)
  81 |         }
  82 |     }

The build fails due to an error related to ViewAnnotationManager.swift in the MapboxMaps library. The error points to a type conversion issue between [UIView : ViewAnnotationOptions] and Dictionary<String, Optional>.RawValue.

Expected behavior

The application should build successfully and work as expected on iOS 18 and xcode 16.0

Notes / preliminary analysis

No response

Additional links and references

No response

[VedantTapadia-RisingTide]

+1

[dadudad1]

a quick fix until the official release... change the annotation variable to:
public var annotations: [String: Optional<Any>] {
var result: [String: Optional<Any>] = [:]
for (view, options) in idsByView.compactMapValues({ [mapboxMap] id in try? mapboxMap.options(forViewAnnotationWithId: id) }) {
let key = String(describing: view)
result[key] = options
}
return result
}

[VedantTapadia-RisingTide]

Which file does this change go with?

[dadudad1]

in ios/Pods/MapboxMaps/Sources/MapboxMaps/Annotations/ViewAnnotationManager.swift as specified in the issue

I am using version 10.1.31

[ChickenBone]

+1

[kckunal2612]

+1

[rprvnraj]

+1

[kbqdev]

Same issues

[artanisdesign]

+1

[matthewhausmantrellus]

+1 from an expo user when building a development client

"RNMapboxMapsVersion": "11.4.0",
"@rnmapbox/maps": "^10.1.3",
"react-native": "0.73.2",
"expo": "50.0.14",

[ShaneZhengNZ]

@dadudad1 To patch the file, I am struggling about how to. Typically, if I want to patch a file temporarily, I would use 'yarn patch', however, in this case, the file in under ios/Pods folder, which is not part of the repo (something that generated by Cocapods?). So, I don't know how to apply the temp fix.

[martmalo]

Any update?

[guneyural]

Still no official fix from maintainers. Using @dadudad1 solution solves the issue.

[ShaneZhengNZ]

@guneyural I doubt it unless you eject your Expo project. With the reasons that I mentioned above, I am struggling to find a proper solution to apply @dadudad1 solution.

Basically, don't build with Xcode 16, then you should be fine. Wait for the official fix.

[vulliza]

@matthewhausmantrellus did you find a fix for expo? I'm in the same boat as you :(

[matthewhausmantrellus]

@matthewhausmantrellus did you find a fix for expo? I'm in the same boat as you :(

npx expo run:ios. There are a number of additional steps potentially depending on the user

[ShaneZhengNZ]

@matthewhausmantrellus I don't understand why do you need additional steps? I am using the same Expo SDK version. I can build the development client in EAS (not locally) with the sdk-50 compatible iOS image.

[yudai524]

This build error occurs when native SDK version is v11.
Therefore just remove RNMapboxMapsVersion from your app.json if you have no reason to use v11.

https://rnmapbox.github.io/docs/install

[Gys]

This build error occurs when native SDK version is v11. Therefore just remove RNMapboxMapsVersion from your app.json if you have no reason to use v11.

There is an PrivacyInfo.xcprivacy issue with rnmapbox. In case of expo it seems the easiest solution is selecting v11, even if the app itself uses v10. See #3447 (comment)

[mfazekas]

I think this is addressed by 10.1.33

[TobiDevloft]

Still having this issue with 10.1.33 unfortunately :/

[pavlo-sodtrack]

+1

[Rashotech]

@mfazekas Am still having same issue in 10.1.33. Kindly help rectify.

Thanks

[mfazekas]

Can someone open a pr with changes, please?

[mpiannucci]

This is all fixed for me by switching the mapbox maps version to 11.8

[RyanTG]

Can someone open a pr with changes, please?

#3696

I'm using new architecture, Expo SDK 52. Build fails with 11.4, succeeds with 11.8. Hope this PR helps.