Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade ink; upgrade openbrush #61

Merged
merged 3 commits into from
Apr 5, 2023
Merged

upgrade ink; upgrade openbrush #61

merged 3 commits into from
Apr 5, 2023

Conversation

boyswan
Copy link
Contributor

@boyswan boyswan commented Apr 2, 2023

Upgrade ink to 4.1.0
Remove 3.0.0 openbrush tag and use latest (for 4.1.0 compatibility)

@Maar-io Maar-io self-requested a review April 5, 2023 10:33
Copy link
Contributor

@Maar-io Maar-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

scale = { package = "parity-scale-codec", version = "3", default-features = false, features = ["derive"] }
scale-info = { version = "2.3", default-features = false, features = ["derive"], optional = true }
openbrush = { tag = "3.0.0", git = "https://github.com/727-Ventures/openbrush-contracts", default-features = false, features = ["access_control", "reentrancy_guard", "psp34"] }
openbrush = { git = "https://github.com/727-Ventures/openbrush-contracts", default-features = false, features = ["access_control", "reentrancy_guard", "psp34"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might be tricky to leave it on master. It might bring compatibility issues very soon

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like 3.1.0 was released, set to the tag!

@Maar-io
Copy link
Contributor

Maar-io commented Apr 5, 2023

please rebase before merge.

@boyswan boyswan merged commit b355323 into main Apr 5, 2023
@boyswan boyswan deleted the upgrade/ink-4.1.0 branch April 5, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants