Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update yarn compile with nightly #60

Merged
merged 5 commits into from
Apr 5, 2023
Merged

Update yarn compile with nightly #60

merged 5 commits into from
Apr 5, 2023

Conversation

Maar-io
Copy link
Contributor

@Maar-io Maar-io commented Mar 31, 2023 •
edited
Loading

Fixes failing integration test in Github action.

The yarn compile is not using nightly.
Update package.json scripts to run nightly

@Maar-io Maar-io marked this pull request as ready for review April 2, 2023 18:38
@Maar-io Maar-io requested review from ilionic and boyswan April 2, 2023 18:39
ilionic
ilionic approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@ilionic ilionic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Not sure why decrease of version ( 0.7 -> 0.6 ). Also redundant extra commented out parts, could be cleaned up

@Maar-io
Copy link
Contributor Author

Maar-io commented Apr 5, 2023

Overall LGTM. Not sure why decrease of version ( 0.7 -> 0.6 ). Also redundant extra commented out parts, could be cleaned up
@ilionic thanks for the review:

  • packages.json version is set to 0.6 to follow other crates. It was wrongly set to 0.7 (by me) previously.
  • Commented code is prepared for ink_e2e test. Boyswan is working on it and will uncomment in his PR.

@Maar-io Maar-io merged commit 9145147 into main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilionic ilionic ilionic approved these changes

@boyswan boyswan Awaiting requested review from boyswan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Maar-io @ilionic