Add batch calls for faster deployment #58
Conversation
| @@ -129,6 +131,22 @@ where | |||
| Ok(()) | |||
| } | |||
|
|
|||
| /// Used to add an asset to a vector of tokens. | |||
| /// tokenId - ID of the token to add the asset to | |||
| /// assetId - ID of the asset to add to the token | |||
There was a problem hiding this comment.
fix comment. It is a vec now
|
I wonder if these could be added as a separate Are we also sure these should be part of the library itself? It would be fairly straightforward for a user to implement these in their own contract if they required them, we could have an example contract to demonstrate. This way we wouldn't have to commit to arbitrary iteration limits, as well as maintaining functionality that is possibly a user concern rather than a library concern. My other thought is that smart contracts aren't really designed for large iteration, so it makes me think that the problem lies elsewhere and that this will just be a means to an end. I do think that this is a bit of an anti-pattern. |
|
I agree with your comment that batch calls should not be in the library files. |
Really like this, much cleaner! |
Replaced with #62