Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix definitions highlighting after field and variable #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Hellzed
Copy link

@Hellzed Hellzed commented Oct 26, 2019

Before this change, description strings are not highlighted after:

  • the first field in a type,
  • the first variable in a field.

image

Descriptions for type fields and field variables are explicitly allowed by the GraphQL spec.

This change fixes highlighting of string values in types and fields, according to the spec.
image

@FallingSnow
Copy link

Any chance of implementing this pull request?

@Hellzed
Copy link
Author

Hellzed commented Feb 26, 2020

@FallingSnow Actually I think it might cause other issues... I think it would just be better to port it to a TreeSitter grammar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants