Add top-level schema caches to Schema::Visibility for better performance #5161
+391
−259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support lazy-loading in development, I had bypassed the existing top-level caches for types, possible types, and schema references. But, that turned out to be noticeably slow when validating lots of queries all at once. So in this PR, I'm trying to have it all:
I wrote a benchmark based on #5151:
Validation benchmark, Warden vs Schema::Visibility
And I got big (10x +) performance gains so far:
So, there are still some wrinkles to smooth out, but it's heading the right direction!
TODO
type => possible_types
and use itVisibility::Profile
type => references
and use itinterface => interface_implementors
〃Profile
? removedef references?
Schema::Visibility::Visit
inProfile
instead of hand-rolled visit codeTopLevel
interacts withpreload: true
andpreload: false
TopLevel
(and rename?) to make sure lazy-loading works as expectedrefresh: true
top_level_profile
?Fixes #5151