Default to re-authorizing scoped items (as documented), fix skipping for connections #4720
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oops -- the default behavior here didn't match the docs. I must have missed it when I switched the default to be opt-in 😖
Since the implementation checked if
scope_items
returned a new object or not, this would have only affected people who implementedscope_items
to return a new object and didn't want that new object to be re-authorized.Also, I fixed the behavior for connections so that they get their
reauthorize_scoped_objects
config from the node type.