Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to re-authorizing scoped items (as documented), fix skipping for connections #4720

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

rmosolgo
Copy link
Owner

@rmosolgo rmosolgo commented Dec 1, 2023

Oops -- the default behavior here didn't match the docs. I must have missed it when I switched the default to be opt-in 😖

Since the implementation checked if scope_items returned a new object or not, this would have only affected people who implemented scope_items to return a new object and didn't want that new object to be re-authorized.

Also, I fixed the behavior for connections so that they get their reauthorize_scoped_objects config from the node type.

@rmosolgo rmosolgo added this to the 2.1.7 milestone Dec 1, 2023
@rmosolgo rmosolgo merged commit 1b157b2 into master Dec 1, 2023
12 checks passed
@rmosolgo rmosolgo deleted the fix-scoped-default branch December 1, 2023 16:34
@bmulholland
Copy link

Thanks for the fix, really appreciate it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants