Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OpenTelemetry legacy trace #4663

Merged
merged 4 commits into from
Oct 12, 2023
Merged

Fix OpenTelemetry legacy trace #4663

merged 4 commits into from
Oct 12, 2023

Conversation

rmosolgo
Copy link
Owner

@rmosolgo rmosolgo mentioned this pull request Oct 12, 2023
Closed
@rmosolgo rmosolgo marked this pull request as ready for review October 12, 2023 20:35
@rmosolgo
Copy link
Owner Author

I ran the OpenTelementry instrumenter tests locally to confirm that this fix worked:

be rake test TEST=/Users/rmosolgo/code/opentelemetry-ruby-contrib/instrumentation/graphql/test/instrumentation/graphql/tracers/graphql_tracer_test.rb
Run options: --seed 22038

# Running:

..........S.......

Finished in 0.044443s, 405.0132 runs/s, 562.5183 assertions/s.

@rmosolgo rmosolgo added this to the 2.1.3 milestone Oct 12, 2023
@rmosolgo rmosolgo merged commit acb7bca into master Oct 12, 2023
12 checks passed
@rmosolgo rmosolgo deleted the fix-opentelementry-legacy-tracer branch October 12, 2023 20:39
@rmosolgo rmosolgo mentioned this pull request Oct 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.3
Development

Successfully merging this pull request may close these issues.

graphql 2.1.2 tests are failing
1 participant
@rmosolgo