Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Schema.default_trace_mode, support separate ancestries for non-default trace modes #4642

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Add Schema.default_trace_mode, support separate ancestries for non-default trace modes #4642

merged 3 commits into from
Oct 3, 2023

Conversation

rmosolgo
Copy link
Owner

@rmosolgo rmosolgo commented Sep 20, 2023 •
edited
Loading

Fixes #4632

Also, since this PR, when building a non-default trace class, a schema will:

  • First, check to see if the superclass has a base class for this mode
  • Then, use the schema's own default mode base class

And it creates a child class out of that.

@rmosolgo rmosolgo mentioned this pull request Sep 20, 2023
Closed
@rmosolgo rmosolgo added this to the 2.1.2 milestone Oct 3, 2023
@rmosolgo rmosolgo merged commit 7c62eb1 into master Oct 3, 2023
@rmosolgo rmosolgo deleted the default-trace-mode branch October 3, 2023 19:52
@swalkinshaw swalkinshaw mentioned this pull request Oct 12, 2023
Closed
@rmosolgo rmosolgo changed the title Add Schema.default_trace_mode Add Schema.default_trace_mode, support separate ancestries for non-default trace modes Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.2
Development

Successfully merging this pull request may close these issues.

trace_mode(:foo, TraceClass) does not stick for child classes
1 participant
@rmosolgo