Use compare_by_identity on some runtime caches #4443
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some hashes in GraphQL-Ruby are by-type caches of things. Those will always have the same objects (Classes) as keys, so we could use compare_by_identity for them (suggested in #4431 (comment))
Initial results are good:
TODO:
schema.after_lazy
to use this runtime method instead (perhaps by addingquery.
orcontext.after_lazy
?) which uses a better cache