Allow 'empty line' comments

rmosolgo · Jun 10, 2024 · 62ea569 · 62ea569
1 parent 68843a0
commit 62ea569
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/lib/graphql/language/comment.rb b/lib/graphql/language/comment.rb
@@ -3,14 +3,14 @@ module GraphQL
   module Language
     module Comment
       def self.print(str, indent: '')
-        lines = []
-        str.split("\n") do |line|
+        lines = str.split("\n").map do |line|
           comment_str = "".dup
           comment_str << indent
           comment_str << "# "
           comment_str << line
-          lines << comment_str
+          comment_str.rstrip
         end
+
         lines.join("\n") + "\n"
       end
     end

diff --git a/lib/graphql/language/parser.rb b/lib/graphql/language/parser.rb
@@ -725,7 +725,7 @@ def value
           advance_token
           NullValue.new(pos: pos, name: "null", filename: @filename, source: self)
         when :COMMENT
-          val = @lexer.token_value.sub('# ', '')
+          val = @lexer.token_value.sub(/^#(\s+)?/, '')
           advance_token
           val
         when :IDENTIFIER

diff --git a/spec/graphql/language/printer_spec.rb b/spec/graphql/language/printer_spec.rb
@@ -151,6 +151,7 @@
           Scalar description
           """
           # Scalar comment
+          #
           # Multiline
           scalar CustomScalar