Merge pull request #1 from jesse-matsec/timeouts

Add timeouts for old ack requests

src/api/_acks.ts

@@ -13,13 +13,15 @@ const REMINDER_FREQUENCY_MS = REMINDER_FREQUENCY_MIN * 60 * 1000;
 
 const DEBUG_CHECK_ALL = false;
 
+const TIMEOUT_INTERVAL = 30 * 24 * 60 * 60 * 1000; // Default timeout interval for ackbot message checking is 30d
+
 export async function checkForReminders() {
 	const now = new Date().getTime();
 	const upperBound = DEBUG_CHECK_ALL ? '+inf' : now - REMINDER_FREQUENCY_MS;
-	console.log('checkForReminders started: ', { now, upperBound });
+	console.log('checkForReminders started: ', { now: now, upperBound });
 
 	const vals = await redis.zrange(REDIS_ACK_KEY, '-inf', upperBound, { byScore: true }) as string[];
-	console.log('checkForReminders got reminders: ', { now, vals });
+	console.log('checkForReminders got reminders: ', { now: now, vals });
 
 	const complete: { channel: string, ts: string }[] = [];
 	const incomplete: { channel: string, ts: string }[] = [];
@@ -32,7 +34,10 @@ export async function checkForReminders() {
 			const { isComplete } = await checkMessageAcks(channel, ts, false);
 			if (isComplete) {
 				complete.push({ channel, ts });
-			} else {
+			} else if (  now > parseInt(ts, 10) + TIMEOUT_INTERVAL ) { // At execution, check if the present time is after the day and time of the original message + 30 days, if so, mark the message as complete (because of timeout)
+				complete.push({ channel, ts });
+			}
+			else {
 				incomplete.push({ channel, ts });
 			}
 		} catch (e) {
@@ -47,8 +52,8 @@ export async function checkForReminders() {
 	if (incomplete.length > 0) {
 		await saveReminders(incomplete);
 	}
-	console.log('checkForReminders done: ', { vals, complete, incomplete, now, upperBound });
-	return { vals, complete, incomplete, now, upperBound };
+	console.log('checkForReminders done: ', { vals, complete, incomplete, now: now, upperBound });
+	return { vals, complete, incomplete, now: now, upperBound };
 }
 
 async function saveReminders(reminders: { channel: string, ts: string }[]): Promise<void> {