Add support for Rails 8.0 #73
Conversation
|
This PR is a draft because it is waiting for cgriego/active_attr#205 to be released. |
| spec.add_runtime_dependency "activemodel", ">= 3.0", "< 8.0" | ||
| spec.add_development_dependency "active_attr", "~> 0.15" | ||
| spec.add_runtime_dependency "activemodel", ">= 3.0", "< 8.1" | ||
| spec.add_development_dependency "active_attr", ">= 0.15.0", "< 0.19" |
There was a problem hiding this comment.
[QUESTION] Please help me understand why this active_attr restriction was necessary as compared to ~> 0.15 (considering the latest release of active_attr is 0.17).
There was a problem hiding this comment.
Because we need cgriego/active_attr#205 which will (probably) be published as active_attr v0.18.0.
There was a problem hiding this comment.
That doesn't explain the difference between "~> 0.15" and ">= 0.15.0", "< 0.19"
[PLEASE REVERT] back to ~> 0.15
| source "https://rubygems.org" | ||
|
|
||
| gem "activemodel", "~> 8.0.0" | ||
| gem "active_attr", github: "leoarnold/active_attr", branch: "leoarnold/rails-8" |
There was a problem hiding this comment.
I'm inclined to merge this PR even though the test suite relies on your private branch at the moment. Would you mind coming back to submit another PR after your active_attr PR is merged?
There was a problem hiding this comment.
I marked this PR as a draft specifically to prevent premature merging. The reason I put up the draft is so that other developers can see that this effort is already in progress and they don't need to investigate themselves (or open issues).
There was a problem hiding this comment.
Why would a "premature" merge be a problem? This gem doesn't have a required runtime dependency on active_attr. ActiveAttr is an optional dependency.
We should be able to merge this PR and when active_attr is updated, projects will get its dependency benefits when it also supports rails 8.
There was a problem hiding this comment.
i.e. Keeping this PR as a draft just holds back those projects that depend on strip_attributes but don't have a dependency on active_attr.
No description provided.