Update matcher to take list of arguments; alias it as #strip_attributes #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmm5t
requested changes
Mar 29, 2020
lib/strip_attributes/matchers.rb
Outdated
| subject.send("#{@attribute}=", " string ") | ||
| subject.valid? | ||
| subject.send(@attribute) == "string" and collapse_spaces?(subject) | ||
| end.all? |
There was a problem hiding this comment.
[PLEASE CHANGE] no need to pass over the array twice:
@attributes.all? do |attribute|
@attribute = attribute
subject.send("#{@attribute}=", " string ")
subject.valid?
subject.send(@attribute) == "string" and collapse_spaces?(subject)
endThere was a problem hiding this comment.
Good catch! Updated, and I also removed the extra unnecessary splats (*)
There was a problem hiding this comment.
Would you like me to squash the commits into one, or is there an automatic way github can do that with the merge (I'm used to gitlab)?
rmm5t
approved these changes
Mar 31, 2020
|
Squashed and merged. Thank you! 🍻 |
|
v1.10.0 released with these changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rmm5t here's a PR for the issue I created: #51
I tried to match your style as much as possible, but please let me know if you'd like me to make any changes.