add regular expression support #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dfguo
commented
Jan 9, 2014
dfguo
commented
- allow stripping off characters defined in options[:regex]
- add test
- readme update
- allow stripping off characters defined in options[:regex] - add test
- add regex example - remove unused test case
|
Thanks for this elegant implementation. Others have suggested something similar to this, but I like this approach well enough to expand the feature-set of strip_attributes. If you could add another commit to address my requested changes to the readme, I'll get this pulled in and schedule a new release after I play around with it a bit. 👍 |
|
Sorry for the delay. Added the examples. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.