Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stale dependencies #70

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Update stale dependencies #70

merged 1 commit into from
Jan 13, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 4, 2021

Updating dependencies to the latest stable versions

@dotemacs
Copy link
Contributor

dotemacs commented Jan 4, 2021

Almost...

Looking into it.

@dotemacs
Copy link
Contributor

dotemacs commented Jan 4, 2021

  1. outdated.md needs to be removed before the PR step is made.
  2. after running lein ancient upgrade, lein test is kicked off

Because the test run is kicked off automatically, no diff is made. PR coming up

@rm-hull
Copy link
Owner

rm-hull commented Jan 5, 2021

Shouldn’t it also bump the versions in project.clj too?

@dotemacs
Copy link
Contributor

dotemacs commented Jan 5, 2021

Shouldn’t it also bump the versions in project.clj too?

There are couple of reasons behind this:

  • deps.edn doesn't have a version number so I didn't look into it
  • some steps are better done manually, for example I could look for a way to bump the version, but what number will the next release be in: x.y.z or x.y.z-SNAPSHOT or something else?

If I were to do this, maybe we can have a workflow that does this: when you create a branch for releasing, say release and you push any commit into it (even an empty commit) with a commit message release: x.y.z (anything after release: , is the next release version):

  • it takes this x.y.z as the release number and checks out master
  • bumps the version number in project.clj with x.y.z
  • tags master with x.y.z & builds the jar and pushes it to Clojars
  • if all the above steps go well, it cleans up by deleting the branch release

The above steps allow you to have flexibility to add any release number

Thoughts?

@dotemacs
Copy link
Contributor

dotemacs commented Jan 5, 2021

Also, please close this PR as the new one for dependency update won't be created if this one is present.

Thanks @rm-hull

@github-actions github-actions bot force-pushed the update-dependencies branch from 1774e2d to d7bf53d Compare January 6, 2021 08:03
@dotemacs
Copy link
Contributor

dotemacs commented Jan 6, 2021

Ah nice, the GitHub Action force pushed to this branch with all the updates

@github-actions github-actions bot force-pushed the update-dependencies branch from d7bf53d to 67e7ce1 Compare January 8, 2021 08:04
@dotemacs
Copy link
Contributor

dotemacs commented Jan 8, 2021

It looks like this is going to run every day, until merged

@rm-hull rm-hull merged commit 849d739 into master Jan 13, 2021
@rm-hull rm-hull deleted the update-dependencies branch January 13, 2021 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants