Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to require pipenv from source #839

Closed
wants to merge 1 commit into from
Closed

Conversation

gitanshu
Copy link
Contributor

@gitanshu gitanshu commented Aug 12, 2019

The latest release of pipenv (2018.11.26) can't resolve archive
URLs, which is how we install dm_control. This issue is resolved in
master branch. So until pipenv makes a new release, garage requires
installing pipenv from source.

See: pypa/pipenv#3148 & pypa/pipenv#3298

@gitanshu gitanshu requested a review from a team as a code owner August 12, 2019 21:04
@gitanshu gitanshu requested a review from a team August 12, 2019 21:04
@ghost ghost requested review from CatherineSue and cheng-kevin and removed request for a team August 12, 2019 21:04
@codecov
Copy link

codecov bot commented Aug 12, 2019

Codecov Report

Merging #839 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #839      +/-   ##
==========================================
- Coverage   73.95%   73.91%   -0.04%     
==========================================
  Files         182      182              
  Lines       10465    10465              
  Branches     1325     1325              
==========================================
- Hits         7739     7735       -4     
- Misses       2357     2360       +3     
- Partials      369      370       +1
Impacted Files Coverage Δ
src/garage/misc/special.py 30.3% <0%> (-3.04%) ⬇️
src/garage/tf/optimizers/first_order_optimizer.py 65.27% <0%> (-2.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6943ac...c5cfc26. Read the comment docs.

The latest release of pipenv (2018.11.26) can't resolve archive
URLs, which is how we install dm_control. This issue is resolved in
master branch. So until pipenv makes a new release, garage requires
installing pipenv from source.
@gitanshu
Copy link
Contributor Author

Closing this in light of #828 (comment)

@gitanshu gitanshu closed this Aug 20, 2019
@gitanshu gitanshu deleted the install_docs branch August 20, 2019 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants