add log

Signed-off-by: Ryan Leung <[email protected]>
rleungx · Sep 7, 2023 · a2d01bd · a2d01bd
1 parent 30892d0
commit a2d01bd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/pkg/mcs/scheduling/server/grpc_service.go b/pkg/mcs/scheduling/server/grpc_service.go
@@ -24,6 +24,7 @@ import (
 	"github.com/tikv/pd/pkg/core"
 	"github.com/tikv/pd/pkg/mcs/registry"
 	"github.com/tikv/pd/pkg/utils/apiutil"
+	"go.uber.org/zap"
 	"google.golang.org/grpc"
 	"google.golang.org/grpc/codes"
 	"google.golang.org/grpc/status"
@@ -72,11 +73,14 @@ func (s *Service) StoreHeartbeat(ctx context.Context, request *schedulingpb.Stor
 	c := s.GetCluster()
 	if c == nil {
 		// TODO: add metrics
+		log.Info("cluster isn't initialized")
 		return &schedulingpb.StoreHeartbeatResponse{Header: &schedulingpb.ResponseHeader{ClusterId: s.clusterID}}, nil
 	}
 
 	// TODO: add metrics
-	c.HandleStoreHeartbeat(request)
+	if err := c.HandleStoreHeartbeat(request); err != nil {
+		log.Error("handle store heartbeat failed", zap.Error(err))
+	}
 	return &schedulingpb.StoreHeartbeatResponse{Header: &schedulingpb.ResponseHeader{ClusterId: s.clusterID}}, nil
 }
 
@@ -85,6 +89,7 @@ func (s *Service) PutStore(ctx context.Context, request *schedulingpb.PutStoreRe
 	c := s.GetCluster()
 	if c == nil {
 		// TODO: add metrics
+		log.Info("cluster isn't initialized")
 		return &schedulingpb.PutStoreResponse{Header: &schedulingpb.ResponseHeader{ClusterId: s.clusterID}}, nil
 	}
 

diff --git a/tests/integrations/mcs/scheduling/server_test.go b/tests/integrations/mcs/scheduling/server_test.go
@@ -99,7 +99,7 @@ func (suite *serverTestSuite) TestAllocIDAfterLeaderChange() {
 	re.NoError(failpoint.Disable("github.com/tikv/pd/pkg/mcs/scheduling/server/fastUpdateMember"))
 }
 
-func (suite *serverTestSuite) TestForwardSchedulingRelated() {
+func (suite *serverTestSuite) TestForwardStoreHeartbeat() {
 	re := suite.Require()
 	tc, err := tests.NewTestSchedulingCluster(suite.ctx, 1, suite.backendEndpoints)
 	re.NoError(err)