-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event rsvps #19
Event rsvps #19
Conversation
Added roxygen2 function definition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, @ledell! 🎉
@@ -48,6 +48,7 @@ | |||
|
|||
# Total number of records matching the query | |||
total_records <- as.integer(res$headers$`x-total-count`) | |||
if (length(total_records) == 0) total_records <- 1L |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I hadn’t considered some calls may not have the x-total-count
#' \dontrun{ | ||
#' urlname <- "rladies-nashville" | ||
#' upcoming_events <- get_events(urlname = urlname, | ||
#' event_status = "upcoming") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be event_status = "past"
to get past events. I assume that's what you wanted since there will always be past events and the next line says: #first event for this group
. I will make the update on master after I merge.
This looks great! Thank you for the contribution. I am just going to post an example of all the possible data points we can return for a single RSVP here in case we want to add anything more in the future. I like the columns you chose to keep, and at this time, I don't think anything more is necessary:
|
Hey @brooklynbagel we've added you as an official contributor to the package! b078b9c |
Would like to be able to access Meetup event RSVPs from
meetupr
. According to the docs:so in order to make it
.fetch_results
had to be modified to handle a response with nox-total-count
header. Hopefully the solution I used works.