Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event rsvps #19

Merged
merged 2 commits into from
Feb 19, 2018
Merged

Event rsvps #19

merged 2 commits into from
Feb 19, 2018

Conversation

brooklynbagel
Copy link
Contributor

Would like to be able to access Meetup event RSVPs from meetupr. According to the docs:

This endpoint returns an un-paginated list of RSVPs

so in order to make it .fetch_results had to be modified to handle a response with no x-total-count header. Hopefully the solution I used works.

@ledell ledell self-assigned this Feb 17, 2018
@ledell ledell removed their assignment Feb 18, 2018
@ledell ledell self-requested a review February 18, 2018 19:53
Copy link
Member

@LucyMcGowan LucyMcGowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @ledell! 🎉

@@ -48,6 +48,7 @@

# Total number of records matching the query
total_records <- as.integer(res$headers$`x-total-count`)
if (length(total_records) == 0) total_records <- 1L
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I hadn’t considered some calls may not have the x-total-count

#' \dontrun{
#' urlname <- "rladies-nashville"
#' upcoming_events <- get_events(urlname = urlname,
#' event_status = "upcoming")
Copy link
Member

@ledell ledell Feb 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be event_status = "past" to get past events. I assume that's what you wanted since there will always be past events and the next line says: #first event for this group. I will make the update on master after I merge.

@ledell
Copy link
Member

ledell commented Feb 19, 2018

This looks great! Thank you for the contribution. I am just going to post an example of all the possible data points we can return for a single RSVP here in case we want to add anything more in the future. I like the columns you chose to keep, and at this time, I don't think anything more is necessary:

> res[[1]]
$created
[1] 1.477601e+12

$updated
[1] 1.477601e+12

$response
[1] "yes"

$guests
[1] 0

$event
$event$id
[1] "234968855"

$event$name
[1] "R-Ladies Nashville Kickoff!"

$event$yes_rsvp_count
[1] 27

$event$time
[1] 1.478561e+12

$event$utc_offset
[1] -21600000


$group
$group$id
[1] 20493986

$group$urlname
[1] "rladies-nashville"

$group$name
[1] "R-Ladies Nashville"

$group$status
[1] "active"

$group$who
[1] "Members"

$group$members
[1] 254

$group$join_mode
[1] "open"

$group$localized_location
[1] "Nashville, TN"

$group$group_photo
$group$group_photo$id
[1] 456624260

$group$group_photo$highres_link
[1] "https://secure.meetupstatic.com/photos/event/5/e/c/4/highres_456624260.jpeg"

$group$group_photo$photo_link
[1] "https://secure.meetupstatic.com/photos/event/5/e/c/4/600_456624260.jpeg"

$group$group_photo$thumb_link
[1] "https://secure.meetupstatic.com/photos/event/5/e/c/4/thumb_456624260.jpeg"

$group$group_photo$type
[1] "event"

$group$group_photo$base_url
[1] "https://secure.meetupstatic.com"



$member
$member$id
[1] 126309962

$member$name
[1] "Aliya Gifford"

$member$photo
$member$photo$id
[1] 256314194

$member$photo$highres_link
[1] "https://secure.meetupstatic.com/photos/member/d/3/b/2/highres_256314194.jpeg"

$member$photo$photo_link
[1] "https://secure.meetupstatic.com/photos/member/d/3/b/2/member_256314194.jpeg"

$member$photo$thumb_link
[1] "https://secure.meetupstatic.com/photos/member/d/3/b/2/thumb_256314194.jpeg"

$member$photo$type
[1] "member"

$member$photo$base_url
[1] "https://secure.meetupstatic.com"


$member$event_context
$member$event_context$host
[1] FALSE



$venue
$venue$id
[1] 24854918

$venue$name
[1] "VUMC Biostatistics Conference Room"

$venue$lat
[1] 36.14601

$venue$lon
[1] -86.80932

$venue$repinned
[1] FALSE

$venue$address_1
[1] "2525 West End Avenue, Suite 1100"

$venue$city
[1] "Nashville"

$venue$country
[1] "us"

$venue$localized_country_name
[1] "USA"

$venue$zip
[1] ""

$venue$state
[1] "TN"

@ledell ledell merged commit ea0e979 into rladies:master Feb 19, 2018
@ledell
Copy link
Member

ledell commented Feb 19, 2018

Hey @brooklynbagel we've added you as an official contributor to the package! b078b9c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants