-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add input fields that allow the user to assign values to various parameters #115
base: dev
Are you sure you want to change the base?
Conversation
Initial workflow proposal:
After successful initial workflow execution:
@Bachibouzouk comments? |
Tasks to do:
|
bff27b6
to
0693f03
Compare
I did some preliminary work, but there are some problems. |
<div class="cell grid-x"> | ||
<label class="cell small-6 input_field_labels">{{ param }}</label> | ||
{% for (param_info, value) in param_details.items() %} | ||
{% if param_info == 'docs_link' %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you loop here, you can assess the value directly with param_details["docs_link"]
@@ -5,6 +5,15 @@ | |||
<!-- WRITE HTML CODE WITHIN THESE block content TAGS --> | |||
{% block content %} | |||
|
|||
{% set project_parameters={ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the structure should be a list of dicts (you can move the name inside with the key name
or label
for example
We should probably create models and use ModelForm to render the inputs from the model instances. The column |
Fix #114
Changes proposed in this pull request:
The following steps were realized, as well (if applies):
black . --exclude docs/
)The following optional steps were realized:
For more information on how to contribute check the [CONTRIBUTING.md](https://github.com/rl
-institut/open_plan/blob/dev/CONTRIBUTING.md).