Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not replace all constraints by default values automatically if one constraint only is missing #953

Merged
merged 3 commits into from
Sep 23, 2022

Conversation

Bachibouzouk
Copy link
Collaborator

@Bachibouzouk Bachibouzouk commented Sep 19, 2022

Fix 161

Changes proposed in this pull request:

  • The constraints are not all set to default values if only one constraint is missing, only the missing constraint is set to default value
  • The default values for the constraints are now located in src/constants.py under the variable DEFAULT_CONSTRAINT_VALUES

The following steps were realized, as well (if applies):

  • Use in-line comments to explain your code
  • Write docstrings to your code (example docstring)
  • For new functionalities: Explain in readthedocs
  • Write test(s) for your new patch of code (pytests, assertion debug messages)
  • Update the CHANGELOG.md
  • Apply black (black . --exclude docs/)
  • Check if benchmark tests pass locally (EXECUTE_TESTS_ON=master pytest)

Please mark above checkboxes as following:

  • Open
  • Done

❌ Check not applicable to this PR

For more information on how to contribute check the CONTRIBUTING.md.

@Bachibouzouk Bachibouzouk changed the title Fix/constraints Do not replace all constraints by default values automatically if one constraint only is missing Sep 19, 2022
@Bachibouzouk Bachibouzouk merged commit 0435647 into dev Sep 23, 2022
@Bachibouzouk Bachibouzouk deleted the fix/constraints branch September 23, 2022 09:27
@Bachibouzouk Bachibouzouk mentioned this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Constraints are not working in MVS
2 participants