Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rtd component models #794

Merged
merged 10 commits into from
Feb 23, 2021
Merged

Feature/rtd component models #794

merged 10 commits into from
Feb 23, 2021

Conversation

SabineHaas
Copy link
Collaborator

@SabineHaas SabineHaas commented Feb 10, 2021

Adress #779

Changes proposed in this pull request:

  • Update component models section in RTD with information on energy storages, heat pumps and HVAC.

Questions:

todos

  • schedule a meeting with @smartie2076 about first two questions
  • write issue: later add link to pvcompare parameter research on heat pumps and TES (costs, temperatures, quality grade etc.)

The following steps were realized, as well (if applies):

  • ❌ Use in-line comments to explain your code
  • ❌ Write docstrings to your code (example docstring)
  • ❌ For new functionalities: Explain in readthedocs
  • ❌ Write test(s) for your new patch of code (pytests, assertion debug messages)
  • Update the CHANGELOG.md
  • ❌ Apply black (black . --exclude docs/)
  • ❌ Check if benchmark tests pass locally (EXECUTE_TESTS_ON=master pytest)

Please mark above checkboxes as following:

  • Open
  • Done

❌ Check not applicable to this PR

For more information on how to contribute check the CONTRIBUTING.md.

@SabineHaas SabineHaas self-assigned this Feb 10, 2021
@SabineHaas
Copy link
Collaborator Author

SabineHaas commented Feb 10, 2021

@smartie2076

I'm not sure about the required level of detail here. Maybe you can check whether you agree with the level of detail checking my first commit on storages (H2 tba).

@smartie2076
Copy link
Collaborator

* [ ]  [Energy Storage] As I understand from `D1.storage_fix()` [here](https://github.com/rl-institut/multi-vector-simulator/blob/454171f449538c451377a278bfd63254ac45c44f/src/multi_vector_simulator/D1_model_components.py#L570) and [here](https://github.com/rl-institut/multi-vector-simulator/blob/454171f449538c451377a278bfd63254ac45c44f/src/multi_vector_simulator/D1_model_components.py#L578) maximum discharge and charge possible in one time step for storage with fixed capacity.
  In contrast, for a storage with optimized cap (`D1.storage_optimize()` a c-rate can be given, see [here](https://github.com/rl-institut/multi-vector-simulator/blob/454171f449538c451377a278bfd63254ac45c44f/src/multi_vector_simulator/D1_model_components.py#L655-L658). (From the Oemof.solph [documentation](https://oemof-solph.readthedocs.io/en/latest/usage.html#genericstorage-component) I also only see the usage of a c-rate for [investment optimization](https://oemof-solph.readthedocs.io/en/latest/usage.html#using-an-investment-object-with-the-genericstorage-component).) Is this right and is this how it should be in MVS?

I am not sure about this at this very moment. We can schedule a meeting to discuss this and the implications.

* [ ]  [HVAC] in case of non air-sourced device, according to [oemof documentation ](https://oemof-solph.readthedocs.io/en/latest/usage.html#transformer-basic)two input busses are needed and efficiencies are assigned to input busses. This could be easily implmented as we allow either multiple input OR multiple output busses see `D1.transformer_constant_efficiency_optimize()`.
  This accounts as well for other conversion technologies with two inputs.

But in that case, is it really an air-sourced device? If you do not care about how much energy you "extract" from air, why measure it by connecting it to the inputs?

For two in/outputs, we dont have benchmark tests yet, so maybe we should have that as a milestone. I guess that means that CHP can not be simulated right now...

docs/Model_Assumptions.rst Show resolved Hide resolved
docs/Model_Assumptions.rst Outdated Show resolved Hide resolved
docs/Model_Assumptions.rst Outdated Show resolved Hide resolved
Thermal energy storage
======================

Thermal energy storages of the type sensible heat storage (SHS) are modelled as *GenericStorage* like described above. The implementation of a specific type of SHS, the stratified thermal energy storage, is described in section :ref:`stratified_tes`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"specific type of SHS"?

Copy link
Collaborator Author

@SabineHaas SabineHaas Feb 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stratified thermal energy storage is a SHS, but specific

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the OGs, SHS are "solar home systems", so that was my confusion.

docs/Model_Assumptions.rst Outdated Show resolved Hide resolved
@smartie2076
Copy link
Collaborator

@smartie2076

I'm not sure about the required level of detail here. Maybe you can check whether you agree with the level of detail checking my first commit on storages (H2 tba).

I like the level of detail.

@SabineHaas
Copy link
Collaborator Author


I am not sure about this at this very moment. We can schedule a meeting to discuss this and the implications.

will do 👍

* [ ]  [HVAC] in case of non air-sourced device, according to [oemof documentation ](https://oemof-solph.readthedocs.io/en/latest/usage.html#transformer-basic)two input busses are needed and efficiencies are assigned to input busses. This could be easily implmented as we allow either multiple input OR multiple output busses see `D1.transformer_constant_efficiency_optimize()`.
  This accounts as well for other conversion technologies with two inputs.

But in that case, is it really an air-sourced device? If you do not care about how much energy you "extract" from air, why measure it by connecting it to the inputs?

No, this is the case for non air source devices.

For two in/outputs, we dont have benchmark tests yet, so maybe we should have that as a milestone. I guess that means that CHP can not be simulated right now...

mhh :/ will this be a problem for the beta release?

@SabineHaas SabineHaas marked this pull request as ready for review February 23, 2021 07:26
@SabineHaas SabineHaas merged commit 26ba003 into dev Feb 23, 2021
@SabineHaas SabineHaas deleted the feature/rtd_component_models branch February 23, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants