-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/rtd component models #794
Conversation
I'm not sure about the required level of detail here. Maybe you can check whether you agree with the level of detail checking my first commit on storages (H2 tba). |
I am not sure about this at this very moment. We can schedule a meeting to discuss this and the implications.
But in that case, is it really an air-sourced device? If you do not care about how much energy you "extract" from air, why measure it by connecting it to the inputs? For two in/outputs, we dont have benchmark tests yet, so maybe we should have that as a milestone. I guess that means that CHP can not be simulated right now... |
Thermal energy storage | ||
====================== | ||
|
||
Thermal energy storages of the type sensible heat storage (SHS) are modelled as *GenericStorage* like described above. The implementation of a specific type of SHS, the stratified thermal energy storage, is described in section :ref:`stratified_tes`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"specific type of SHS"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stratified thermal energy storage is a SHS, but specific
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the OGs, SHS are "solar home systems", so that was my confusion.
I like the level of detail. |
will do 👍
No, this is the case for non air source devices.
mhh :/ will this be a problem for the beta release? |
…/multi-vector-simulator into feature/rtd_component_models
Adress #779
Changes proposed in this pull request:
component models
section in RTD with information on energy storages, heat pumps and HVAC.Questions:
D1.storage_fix()
here and here maximum discharge and charge possible in one time step for storage with fixed capacity.In contrast, for a storage with optimized cap (
D1.storage_optimize()
a c-rate can be given, see here. (From the Oemof.solph documentation I also only see the usage of a c-rate for investment optimization.) Is this right and is this how it should be in MVS?D1.transformer_constant_efficiency_optimize()
.This accounts as well for other conversion technologies with two inputs.
todos
The following steps were realized, as well (if applies):
black . --exclude docs/
)EXECUTE_TESTS_ON=master pytest
)Please mark above checkboxes as following:
❌ Check not applicable to this PR
For more information on how to contribute check the CONTRIBUTING.md.