Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renewable factor and renewable share of local generation #637

Merged
merged 28 commits into from
Nov 11, 2020

Conversation

smartie2076
Copy link
Collaborator

@smartie2076 smartie2076 commented Nov 6, 2020

Fix #636

Changes proposed in this pull request:

  • RTD: Introduce Renewable share of local generation (d099dec)
    ❌ RTD: Introduce Share of demand supplied by renewables (see argument made in Renewable share calculation can be misleading #636)
  • RTD: Detail KPI of Renewable factor (d099dec)
  • Define Renewable share of local generation in a seperate function
  • Define Renewable share with energy carrier weighting
  • Adapt benchmark test for both KPI

The following steps were realized, as well (if applies):

  • Use in-line comments to explain your code
  • Write docstrings to your code (example docstring)
  • For new functionalities: Explain in readthedocs
  • Write test(s) for your new patch of code (pytests, assertion debug messages)
  • Update the CHANGELOG.md
  • Apply black (black . --exclude docs/)
  • Check if benchmark tests pass locally (EXECUTE_TESTS_ON=master pytest)

Please mark above checkboxes as following:

  • Open
  • Done

❌ Check not applicable to this PR

For more information on how to contribute check the CONTRIBUTING.md.

@smartie2076 smartie2076 changed the title Updated Changelog.md: Planned changes in PR Renewable factor and renewable share of local generation Nov 6, 2020
@smartie2076
Copy link
Collaborator Author

@SabineHaas @Bachibouzouk I now did a mini-rebase of this PR, I hope that helps a bit with the review. Whats left is to adapt one or two benchmark tests so that they also test the functionality of the KPI.

@smartie2076 smartie2076 added the enhancement New feature or request label Nov 6, 2020
@smartie2076 smartie2076 self-assigned this Nov 6, 2020
Copy link
Collaborator

@Bachibouzouk Bachibouzouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spotted a few typos. I made a few recommendations as well, you can apply them if you agree to them

CHANGELOG.md Outdated Show resolved Hide resolved
docs/MVS_Outputs.rst Outdated Show resolved Hide resolved
docs/MVS_Outputs.rst Outdated Show resolved Hide resolved
docs/MVS_Outputs.rst Outdated Show resolved Hide resolved
docs/MVS_Outputs.rst Outdated Show resolved Hide resolved
src/multi_vector_simulator/E3_indicator_calculation.py Outdated Show resolved Hide resolved
src/multi_vector_simulator/E3_indicator_calculation.py Outdated Show resolved Hide resolved
tests/test_E3_indicator_calculation.py Outdated Show resolved Hide resolved
tests/test_benchmark_KPI.py Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@smartie2076 smartie2076 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adressing comments that can be solved online

docs/MVS_Outputs.rst Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
docs/MVS_Outputs.rst Outdated Show resolved Hide resolved
docs/MVS_Outputs.rst Outdated Show resolved Hide resolved
src/multi_vector_simulator/E3_indicator_calculation.py Outdated Show resolved Hide resolved
@smartie2076 smartie2076 merged commit 57f0121 into dev Nov 11, 2020
@smartie2076 smartie2076 deleted the fix_renewable_share branch November 11, 2020 12:20
@smartie2076 smartie2076 mentioned this pull request Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renewable share calculation can be misleading
2 participants