-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renewable factor and renewable share of local generation #637
Conversation
…add_total_renewable_and_non_renewable_energy_origin` And `E3.renewable_share` to `E3.add_renewable_factor`
…ctor constraint` in all files (python, messages, RTD, json, tests, csv), so that this is in line with the definition and does not cause any confusion.
…_local_generation
beb7ad3
to
2fa9ec6
Compare
@SabineHaas @Bachibouzouk I now did a mini-rebase of this PR, I hope that helps a bit with the review. Whats left is to adapt one or two benchmark tests so that they also test the functionality of the KPI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spotted a few typos. I made a few recommendations as well, you can apply them if you agree to them
…ulator into feature/energy_busses # Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adressing comments that can be solved online
Co-authored-by: Pierre Francois <[email protected]>
…newable_share_mini # Conflicts: # CHANGELOG.md
Fix #636
Changes proposed in this pull request:
Renewable share of local generation
(d099dec)❌ RTD: Introduce
Share of demand supplied by renewables
(see argument made in Renewable share calculation can be misleading #636)Renewable factor
(d099dec)Renewable share of local generation
in a seperate functionRenewable share
with energy carrier weightingThe following steps were realized, as well (if applies):
black . --exclude docs/
)EXECUTE_TESTS_ON=master pytest
)Please mark above checkboxes as following:
❌ Check not applicable to this PR
For more information on how to contribute check the CONTRIBUTING.md.