-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove label parameter where it is not needed #602
Conversation
…", "economic_data", "simulation_settings
…r assets by column names
@smartie2076, I left |
Ok |
Co-authored-by: Pierre Francois <[email protected]>
aren't |
I added the word "for" to make it clearer: I would add this to the changelog if you agree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you run the test with EXECUTE_TESTS_ON=master? if yes, then I approve the PR
Yes, I did. Thanks for reviewing! |
If it is your own branch, you can do rebase instead of merging dev into the branch :) |
with rebase I got a merge conflict, while with merging I didn't.. |
Parameter label from input csv files; label is now set by filenames (for `project_data`, `economic_data`, `simulation_settings`) and column headers (for `energyConsumption`, `energyConversion`, `energyProduction`, `energyProviders`), special for storage: `filename` + `column header` (#602)
Fix #375
Changes proposed in this pull request:
project_data
,economic_data
,simulation_settings
) and column names (forenergyConsumption
,energyConversion
,energyProduction
,energyProviders
), special for storage:filename
+column name
The following steps were realized, as well (if applies):
black . --exclude docs/
)EXECUTE_TESTS_ON=master pytest
)Please mark above checkboxes as following:
❌ Check not applicable to this PR
For more information on how to contribute check the CONTRIBUTING.md.