Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve assert error msg #578

Merged
merged 6 commits into from
Sep 26, 2020
Merged

Conversation

Bachibouzouk
Copy link
Collaborator

@Bachibouzouk Bachibouzouk commented Sep 26, 2020

Addresses part of #540

Changes proposed in this pull request:

  • Write explicit test failure messages hinting to the developer what is the meta cause of the test failure

The following steps were realized, as well (if applies):

  • Write docstrings to your code
  • Update the CHANGELOG.md
  • Apply black (black . --exclude docs/)
  • Check if benchmark tests pass locally (EXECUTE_TESTS_ON=master pytest)

For more information on how to contribute check the CONTRIBUTING.md.

@Bachibouzouk Bachibouzouk changed the title Feature/improve assert error msg Improve assert error msg Sep 26, 2020
@Bachibouzouk Bachibouzouk merged commit 29a09b1 into dev Sep 26, 2020
@Bachibouzouk Bachibouzouk deleted the feature/improve-assert-error-msg branch September 26, 2020 18:12
@Bachibouzouk
Copy link
Collaborator Author

@smartie2076 you can still look at the PR and let me know if there is something which need change

@Bachibouzouk Bachibouzouk mentioned this pull request Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant