-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix optimizedAddCap of non-dispatchable sources #498
Conversation
@smartie2076 for the plans/status see "Changes proposed in this pull request:" and previous commits. |
@SabineHaas, the structure of files has changed, you will have to copy-paste your changes in the new C files located under |
Co-authored-by: smartie2076 <[email protected]>
I am taking over this PR now, and am trying to close it today. Checkpoints:
Current status of the excessive excess gereration test:
Fixed with 2c17b9c. @SabineHaas: Previously, you defined
I also think that checking for
|
…ttps://github.com/smartie2076/mvs_eland into fix/opimizedaddcap_non_dispatch_sources # Conflicts: # CHANGELOG.md
@Bachibouzouk this is ready to merge after the tests ran though. I did the local pytests (master), and they all passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already passed through @SabineHaas and @smartie2076 , so it counts as a review
Fix #446,
Fix #461,
Fix #2
Changes proposed in this pull request:
timeseries_normalized
are calculated for alltimeseries
of non-dispatchable sources now (before only ifoptimizeCap==True
) see Fix optimizedAddCap of non-dispatchable sources #562The following steps were realized, as well (if applies):
black . --exclude docs/
)EXECUTE_TESTS_ON=master pytest
)Please mark above checkboxes as following:
❌ Check not applicable to this PR
For more information on how to contribute check the CONTRIBUTING.md.