Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marie lataretu/issue23 #39

Merged
merged 14 commits into from
Jul 21, 2021
Merged

Marie lataretu/issue23 #39

merged 14 commits into from
Jul 21, 2021

Conversation

MarieLataretu
Copy link
Collaborator

  • modularized alignment handling for easy bam file filtering
  • bam soft-clipped filter option:
    • by the total number of soft-clipped positions or
    • relative number of soft-clipped positions (relative to the read length)

@MarieLataretu MarieLataretu requested a review from hoelzer July 7, 2021 17:24
Copy link
Member

@hoelzer hoelzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool @MarieLataretu !

So one main part is now the additional script you wrote to identify soft-clipped reads? I think that's really a feature others are lacking or can not consider if they just run minimap2 and some downstream commands manually. So that's cool.

You added this to prevent false read mappings just bc/ minimap2 soft clips huge parts of a read to get it somehow aligned to the reference?

@MarieLataretu
Copy link
Collaborator Author

So one main part is now the additional script you wrote to identify soft-clipped reads? I think that's really a feature others are lacking or can not consider if they just run minimap2 and some downstream commands manually. So that's cool.

Yes, one can filter by the total number of soft-clipped nts or a relative number (relative to the read length). (And I removed a lot of redundant code.)

You added this to prevent false read mappings just bc/ minimap2 soft clips huge parts of a read to get it somehow aligned to the reference?

We saw that in at least one test data set. So with the soft-clip parameter, one can filter the reads more stringent by not trusting the mapped reads with lots of soft-clipped nts.


Ah, what might be missing are the fastq files from the bam output from the soft-clip filter process

@hoelzer
Copy link
Member

hoelzer commented Jul 21, 2021

We saw that in at least one test data set. So with the soft-clip parameter, one can filter the reads more stringent by not trusting the mapped reads with lots of soft-clipped nts.

cool!

@MarieLataretu
Copy link
Collaborator Author

Should work now :)

Feel free to test or merge directly!

@hoelzer
Copy link
Member

hoelzer commented Jul 21, 2021

cool, in the advent of buisiness - I merge :D We anyway need to do then a larger master merge and testing for a release I guess

@hoelzer hoelzer merged commit afd98a2 into dev Jul 21, 2021
@MarieLataretu MarieLataretu deleted the MarieLataretu/issue23 branch January 4, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants