Fix parsing token expiration time and small cleanup #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The golang oauth2 library's `Token` doesn't have an "expires_in" field. Instead oauth2 internally parses the expiration into a future unix timestamp. So before this patch, the tokens that oauth2device was producing didn't properly capture the expiration time. This patch fixes it by copying the logic from oauth2, which is unfortunately not exposed in a way that we can directly use. Change-Id: Idec2632c5d4cb272d9d2e8e0099972ad9dda9c3d
Change-Id: Idab0ebad1f5f10b0a40a9a6f3663d74a5a9f8e1c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where oauth2device wasn't properly passing along the token expiration to the oauth2 library. That library expects there to be a field named
Expiry, which is the concrete time it expires, rather than a relative time. This resulted in the oauth2 not renewing the tokens when they actually expired.It also makes sure to close the bodies, and breaks a dependency cycle running the tests.