Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to reduce maintanence effort of RJSF by explicitly documenting some philosophy #707

Merged
merged 1 commit into from
Oct 13, 2017
Merged

Conversation

glasserc
Copy link
Contributor

Reasons for making this change

I'd like to add @olzraiti and @knilink as maintainers to the project, but I thought that before I did that, I should try to formalize what I understood to be the RJSF "philosophy". It is my hope that this can give all maintainers a shared understanding of what react-jsonschema-form is and should be, and therefore give all maintainers confidence to merge a PR if it conforms to that philosophy, even if other maintainers are unavailable. Additionally, I'd like for contributors to be able to tell, before writing a single line of code or even understanding any of the rjsf architecture, whether their PR is likely to be accepted or not.

The philosophical notes are things I took from my notes and are probably not complete. People with a deeper understanding of the project than I have are welcome to offer their own bits of rjsf design or philosophy.

While I was here, I decided that maybe adding a couple of FAQ entries will reduce the maintenance burden of this project by clarifying what the status of certain much-demanded features is.

Checklist

  • I'm updating documentation
    • I've checked the rendering of the Markdown text I've added
    • If I'm adding a new section, I've updated the Table of Content

@glasserc
Copy link
Contributor Author

I've now invited the above-mentioned contributors to collaborate on this repo. Be sure to use your powers for good instead of evil, etc. Also, with great maintainership comes great renovation. I've been thinking that maybe we should revise the pull request template and issue template, what do you think?

@glasserc glasserc merged commit c0ab365 into rjsf-team:master Oct 13, 2017
@glasserc glasserc deleted the add-maintainers branch October 13, 2017 19:19
@olzraiti
Copy link
Contributor

Sorry for the delayed answer!

I'm honored by your request, but unfortunately I don't have the time at the moment for maintaining an upstream library. I've used work hours for the PRs I've provided and I started working only 3 days a week since I'm continuing my CS studies, and maintaining an upstream library would create too much overhead. Also, I've been asked multiple times to give feedback on some PRs, but I never really read the PRs because they were about features that I don't need, so I'm not sure if I'd be a good maintainer. I will keep providing PRs and feedback on issues that concern my use cases though.

I could just accept the request and occasionally handle PRs/issues when I happen to stumble upon them. Realistically that wouldn't happen very often, and I honestly can't sign this clause: "with great maintainership comes great renovation" :)

I hope this isn't too discouraging - I'm just being honest & transparent and I'm sure you understand my angle here. Working with RJSF has been a thrill! Collaborating with open source projects has that warm, fuzzy feeling to it.

@glasserc
Copy link
Contributor Author

Refs #623 (comment).

@glasserc glasserc mentioned this pull request Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants