Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json (peer to utils) #3670

Closed
wants to merge 1 commit into from
Closed

Conversation

aodinok
Copy link

@aodinok aodinok commented May 15, 2023

Fixes: #3669

Reasons for making this change

[Please describe them here]

If this is related to existing tickets, include links to them as well. Use the syntax fixes #[issue number] (ex: fixes #123).

If your PR is non-trivial and you'd like to schedule a synchronous review, please add it to the weekly meeting agenda: https://docs.google.com/document/d/12PjTvv21k6LIky6bNQVnsplMLLnmEuypTLQF8a-8Wss/edit

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@siketyan
Copy link
Contributor

I think we also need to fix this in other packages such as

.

@tjbugh
Copy link

tjbugh commented May 15, 2023

There seems to be a script that updates all the peerDependencies when run.
You might want to follow the releasing documentation, which includes running the npm run post-versioning script, which updates the peerDependencies.

@heath-freenome
Copy link
Member

There seems to be a script that updates all the peerDependencies when run. You might want to follow the releasing documentation, which includes running the npm run post-versioning script, which updates the peerDependencies.

As the developer of that script I have identified some issues with it that causes it not to run properly. I have manually updated all of the relevant package*.json file in #3675 and will close this PR in favor of that

nickgros added a commit to nickgros/react-jsonschema-form that referenced this pull request Jul 14, 2023
heath-freenome added a commit that referenced this pull request Jul 14, 2023
…3770)

* Fix #3758 by removing `ErrorList` from docs, which should have been removed when v5 was released

* Fix #3670 - fix bad theme imports in docs

---------

Co-authored-by: Heath C <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@rjsf/[email protected] does not satisfy peer dependency of other rjsf packages in the same version
4 participants