Patch mui range slider for 0 value #3465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@c-dante I just merged a PR that is causing conflicts in the |
CHANGELOG.md
Outdated
Comment on lines
18
to
28
| # 5.2.1 (upcoming) | ||
|
|
||
| ## @rjsf/material-ui | ||
| - Patch `RangeWidget` to support `0` as range slider value | ||
|
|
||
| ## @rjsf/mui | ||
| - Patch `RangeWidget` to support `0` as range slider value | ||
|
|
||
| ## Dev / docs / playground | ||
| - Updated the playground's `numbers` example to use a range slider with a valid negative and `0` value | ||
|
|
There was a problem hiding this comment.
Actually, since I haven't cut the 5.2.0 release please append them onto the associated sections for that release
heath-freenome
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
fixes #3458
If your PR is non-trivial and you'd like to schedule a synchronous review, please add it to the weekly meeting agenda: https://docs.google.com/document/d/12PjTvv21k6LIky6bNQVnsplMLLnmEuypTLQF8a-8Wss/edit
Checklist
npm run test:updateto update snapshots, if needed.