fix: Add generic type support to the semantic-ui theme #3356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partially fix: rjsf-team#3072 by adding generic type support to the semantic-ui theme as follows: - In `@rjsf/utils` added a missing generic to the `EnumOptionsType` in the `WidgetProps` - In `@rjsf/mui` added generic type support as follows: - Updated all of the template and widget components to add the `T = any`, `S extends StrictRJSFSchema = RJSFSchema` and `F extends FormContextType = any` generics on the function definitions, types and utility function calls - Added a `generateForm<T, S, F>()` function to `SemanticUIForm.tsx`, exporting it and exporting the default `SemanticUIForm` as a call to `generateForm()` - Added a `generateTemplates<T, S, F>()` function to the `Templates.tsx`, exporting it and exporting the default `Templates` as a call to `generateTemplates()` - Added a `generateTheme<T, S, F>()` function to the `Theme.tsx`, exporting it and exporting the default `Theme` as a call to `generateTheme()` - Added a `generateWidgets<T, S, F>()` function to the `Widgets.tsx`, exporting it and exporting the default `Widgets` as a call to `generateWidgets()` - Updated the main `index.ts` for the theme to also export the `generateXXX()` functions - Updated the types and functions in the `utils.ts` file to add the generics - Updated the `CHANGELOG.md` accordingly
nickgros
approved these changes
Jan 7, 2023
jacqueswho
approved these changes
Jan 7, 2023
shijistar
pushed a commit
to shijistar/react-jsonschema-form
that referenced
this pull request
Jun 8, 2023
partially fix: rjsf-team#3072 by adding generic type support to the semantic-ui theme as follows: - In `@rjsf/utils` added a missing generic to the `EnumOptionsType` in the `WidgetProps` - In `@rjsf/mui` added generic type support as follows: - Updated all of the template and widget components to add the `T = any`, `S extends StrictRJSFSchema = RJSFSchema` and `F extends FormContextType = any` generics on the function definitions, types and utility function calls - Added a `generateForm<T, S, F>()` function to `SemanticUIForm.tsx`, exporting it and exporting the default `SemanticUIForm` as a call to `generateForm()` - Added a `generateTemplates<T, S, F>()` function to the `Templates.tsx`, exporting it and exporting the default `Templates` as a call to `generateTemplates()` - Added a `generateTheme<T, S, F>()` function to the `Theme.tsx`, exporting it and exporting the default `Theme` as a call to `generateTheme()` - Added a `generateWidgets<T, S, F>()` function to the `Widgets.tsx`, exporting it and exporting the default `Widgets` as a call to `generateWidgets()` - Updated the main `index.ts` for the theme to also export the `generateXXX()` functions - Updated the types and functions in the `utils.ts` file to add the generics - Updated the `CHANGELOG.md` accordingly
shijistar
pushed a commit
to shijistar/react-jsonschema-form
that referenced
this pull request
Jun 8, 2023
partially fix: rjsf-team#3072 by adding generic type support to the semantic-ui theme as follows: - In `@rjsf/utils` added a missing generic to the `EnumOptionsType` in the `WidgetProps` - In `@rjsf/mui` added generic type support as follows: - Updated all of the template and widget components to add the `T = any`, `S extends StrictRJSFSchema = RJSFSchema` and `F extends FormContextType = any` generics on the function definitions, types and utility function calls - Added a `generateForm<T, S, F>()` function to `SemanticUIForm.tsx`, exporting it and exporting the default `SemanticUIForm` as a call to `generateForm()` - Added a `generateTemplates<T, S, F>()` function to the `Templates.tsx`, exporting it and exporting the default `Templates` as a call to `generateTemplates()` - Added a `generateTheme<T, S, F>()` function to the `Theme.tsx`, exporting it and exporting the default `Theme` as a call to `generateTheme()` - Added a `generateWidgets<T, S, F>()` function to the `Widgets.tsx`, exporting it and exporting the default `Widgets` as a call to `generateWidgets()` - Updated the main `index.ts` for the theme to also export the `generateXXX()` functions - Updated the types and functions in the `utils.ts` file to add the generics - Updated the `CHANGELOG.md` accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
partially fix: #3072 by adding generic type support to the semantic-ui theme as follows:
@rjsf/utilsadded a missing generic to theEnumOptionsTypein theWidgetProps@rjsf/muiadded generic type support as follows:T = any,S extends StrictRJSFSchema = RJSFSchemaandF extends FormContextType = anygenerics on the function definitions, types and utility function callsgenerateForm<T, S, F>()function toSemanticUIForm.tsx, exporting it and exporting the defaultSemanticUIFormas a call togenerateForm()generateTemplates<T, S, F>()function to theTemplates.tsx, exporting it and exporting the defaultTemplatesas a call togenerateTemplates()generateTheme<T, S, F>()function to theTheme.tsx, exporting it and exporting the defaultThemeas a call togenerateTheme()generateWidgets<T, S, F>()function to theWidgets.tsx, exporting it and exporting the defaultWidgetsas a call togenerateWidgets()index.tsfor the theme to also export thegenerateXXX()functionsutils.tsfile to add the genericsCHANGELOG.mdaccordinglyChecklist
npm run test:updateto update snapshots, if needed.