fix: Improve support for remix by adding name on all input elements #3145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Added
name
to elements that were missing it to better support remix.Also, fixes #2355, #2138 by improving the ids we use for checkboxes and radio widgets
name
prop to the any widget that was missing it to support remixname={id}
for all elements since they are logically part of the same input even though theid
s have different values since they need to be unique on the pageCheckboxWidgets
code to eliminate a ternary in favor of a simpleinline={inline}
property since all the rest of the props were the sameForm
that would break the ui in the browserid
and others did not supportname
DateTimeWidget
which was still using theTextInput
-from-widgets pattern instead ofBaseInputTemplate
-from-registry patternkey
props, andname
was set toname
which may not be unique, so switched them toid
npm run test:update
to update the snapshots with the newname
s andid
sCHANGELOG.md
file accordingly, moving a comment frombeta.9
tobeta.10
Checklist
npm run test:update
to update snapshots, if needed.