Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Render Custom widget for standalone array fields #2697

Conversation

alfonsoar
Copy link
Member

@alfonsoar alfonsoar commented Feb 9, 2022

Reasons for making this change

This PR should fix #1385

It allows developers to specify a array in the schema without having to specify an enum or uniqueItems.

Checklist

  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm updating documentation
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

CHANGELOG.md Outdated Show resolved Hide resolved
@alfonsoar
Copy link
Member Author

There are a ton of package-lock.json changes. Not sure if that is expected but it's a bit risky. Should we just omit them?

Copy link
Member

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation we need to change:

Copy link
Member

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert package-lock.json changes, keep them locally if needed

CHANGELOG.md Outdated Show resolved Hide resolved
packages/core/src/utils.js Outdated Show resolved Hide resolved
packages/core/src/components/fields/ArrayField.js Outdated Show resolved Hide resolved
packages/core/src/utils.js Outdated Show resolved Hide resolved
@alfonsoar alfonsoar force-pushed the feat/support-custom-widgets-with-array-fields branch from 4f341eb to 90f7120 Compare February 11, 2022 21:09
packages/core/src/utils.js Outdated Show resolved Hide resolved
@epicfaace epicfaace changed the title feat: Render Custom widget for standlone array fields feat: Render Custom widget for standalone array fields Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

custom widget for array fields with no enums or uniqueItems set to true
3 participants