-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Render Custom widget for standalone array fields #2697
feat: Render Custom widget for standalone array fields #2697
Conversation
There are a ton of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation we need to change:
- https://react-jsonschema-form.readthedocs.io/en/latest/advanced-customization/custom-templates/#arrayfieldtemplate - add a note at beginning that mentions you can use ui:widget for arrays as well
- https://react-jsonschema-form.readthedocs.io/en/latest/advanced-customization/custom-widgets-fields/#adding-your-own-custom-widgets - add "array" as a type that supports widgets
- https://react-jsonschema-form.readthedocs.io/en/latest/usage/arrays/#multiple-choice-list - put "MCL" under a new section called "custom widgets", also talk about how you can use a custom widget in general for an array
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert package-lock.json changes, keep them locally if needed
4f341eb
to
90f7120
Compare
Reasons for making this change
This PR should fix #1385
It allows developers to specify a array in the schema without having to specify an
enum
oruniqueItems
.Checklist